From 1be1979c05e75f6757d46ba89bec0542c5038fa1 Mon Sep 17 00:00:00 2001 From: Nick Fisher Date: Thu, 17 Apr 2025 13:34:18 +0800 Subject: [PATCH] rename requestAnimationFrame to requestFrame --- thermion_dart/lib/src/viewer/src/ffi/src/ffi_filament_app.dart | 3 ++- .../native/include/c_api/ThermionDartRenderThreadApi.h | 2 +- thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/thermion_dart/lib/src/viewer/src/ffi/src/ffi_filament_app.dart b/thermion_dart/lib/src/viewer/src/ffi/src/ffi_filament_app.dart index 7c2c9bda..dc8aff99 100644 --- a/thermion_dart/lib/src/viewer/src/ffi/src/ffi_filament_app.dart +++ b/thermion_dart/lib/src/viewer/src/ffi/src/ffi_filament_app.dart @@ -587,7 +587,7 @@ class FFIFilamentApp extends FilamentApp { completer.complete(true); }); - RenderThread_requestAnimationFrame(callback.nativeFunction.cast()); + RenderThread_requestFrame(callback.nativeFunction.cast()); try { await completer.future.timeout(Duration(seconds: 1)); @@ -669,6 +669,7 @@ class FFIFilamentApp extends FilamentApp { PixelDataFormat pixelDataFormat = PixelDataFormat.RGBA, PixelDataType pixelDataType = PixelDataType.FLOAT, Future Function(View)? beforeRender}) async { + if (swapChain == null) { if (_swapChains.isEmpty) { throw Exception("No swapchains registered"); diff --git a/thermion_dart/native/include/c_api/ThermionDartRenderThreadApi.h b/thermion_dart/native/include/c_api/ThermionDartRenderThreadApi.h index 313c280f..ee5c3fea 100644 --- a/thermion_dart/native/include/c_api/ThermionDartRenderThreadApi.h +++ b/thermion_dart/native/include/c_api/ThermionDartRenderThreadApi.h @@ -16,7 +16,7 @@ namespace thermion EMSCRIPTEN_KEEPALIVE void RenderThread_create(); EMSCRIPTEN_KEEPALIVE void RenderThread_destroy(); - EMSCRIPTEN_KEEPALIVE void RenderThread_requestAnimationFrame(void (*onComplete)()); + EMSCRIPTEN_KEEPALIVE void RenderThread_requestFrame(void (*onComplete)()); EMSCRIPTEN_KEEPALIVE void RenderThread_setRenderTicker(TRenderTicker *tRenderTicker); EMSCRIPTEN_KEEPALIVE void RenderThread_addTask(void (*task)()); diff --git a/thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp b/thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp index 31011c44..f71abe34 100644 --- a/thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp +++ b/thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp @@ -63,7 +63,7 @@ extern "C" _renderThread->setRenderTicker(renderTicker); } - EMSCRIPTEN_KEEPALIVE void RenderThread_requestAnimationFrame(void (*onComplete)()) { + EMSCRIPTEN_KEEPALIVE void RenderThread_requestFrame(void (*onComplete)()) { _renderThread->requestFrame(onComplete); }