From 5287c108f93de0ac9aa14dd64cf6942e3b5cb942 Mon Sep 17 00:00:00 2001 From: Nick Fisher Date: Mon, 4 Mar 2024 21:43:56 +0800 Subject: [PATCH] rename getMeshNames to getChildEntities --- lib/filament_controller.dart | 5 +++-- lib/filament_controller_ffi.dart | 9 +++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/filament_controller.dart b/lib/filament_controller.dart index 59bf2f5f..105deee4 100644 --- a/lib/filament_controller.dart +++ b/lib/filament_controller.dart @@ -597,9 +597,10 @@ abstract class FilamentController { FilamentEntity parent, String childName); /// - /// Lists all child meshes under the given entity. + /// List all child entities under the given entity. /// - Future> getMeshNames(FilamentEntity entity, {bool async = true}); + Future> getChildEntities(FilamentEntity entity, + {bool renderableOnly = true}); /// /// If [recording] is set to true, each frame the framebuffer/texture will be written to /tmp/output_*.png. diff --git a/lib/filament_controller_ffi.dart b/lib/filament_controller_ffi.dart index 925611ac..0beb5c3e 100644 --- a/lib/filament_controller_ffi.dart +++ b/lib/filament_controller_ffi.dart @@ -1436,12 +1436,13 @@ class FilamentControllerFFI extends FilamentController { return childEntity; } - Future> getMeshNames(FilamentEntity entity, - {bool async = false}) async { - var count = get_entity_count(_sceneManager!, entity, true); + @override + Future> getChildEntities(FilamentEntity entity, + {bool renderableOnly = false}) async { + var count = get_entity_count(_sceneManager!, entity, renderableOnly); var names = []; for (int i = 0; i < count; i++) { - var name = get_entity_name_at(_sceneManager!, entity, i, true); + var name = get_entity_name_at(_sceneManager!, entity, i, renderableOnly); if (name == nullptr) { throw Exception("Failed to find mesh at index $i"); }