From 671949a5cde59660e591452d6eb01db93209af1b Mon Sep 17 00:00:00 2001 From: Nick Fisher Date: Sat, 10 May 2025 09:03:46 +0800 Subject: [PATCH] transformToUnitCube returns bool (false when transform instance can't be found) --- thermion_dart/lib/src/bindings/src/thermion_dart_ffi.g.dart | 4 ++-- .../lib/src/filament/src/implementation/ffi_asset.dart | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/thermion_dart/lib/src/bindings/src/thermion_dart_ffi.g.dart b/thermion_dart/lib/src/bindings/src/thermion_dart_ffi.g.dart index 15164113..ba124147 100644 --- a/thermion_dart/lib/src/bindings/src/thermion_dart_ffi.g.dart +++ b/thermion_dart/lib/src/bindings/src/thermion_dart_ffi.g.dart @@ -1125,9 +1125,9 @@ external void TransformManager_setTransform( double4x4 transform, ); -@ffi.Native, EntityId, Aabb3)>( +@ffi.Native, EntityId, Aabb3)>( isLeaf: true) -external void TransformManager_transformToUnitCube( +external bool TransformManager_transformToUnitCube( ffi.Pointer tTransformManager, int entityId, Aabb3 boundingBox, diff --git a/thermion_dart/lib/src/filament/src/implementation/ffi_asset.dart b/thermion_dart/lib/src/filament/src/implementation/ffi_asset.dart index 291124e7..9b9adca3 100644 --- a/thermion_dart/lib/src/filament/src/implementation/ffi_asset.dart +++ b/thermion_dart/lib/src/filament/src/implementation/ffi_asset.dart @@ -469,8 +469,10 @@ class FFIAsset extends ThermionAsset { /// /// Future transformToUnitCube() async { - TransformManager_transformToUnitCube( - app.transformManager, entity, SceneAsset_getBoundingBox(asset)); + if (!TransformManager_transformToUnitCube( + app.transformManager, entity, SceneAsset_getBoundingBox(asset))) { + throw Exception("Failed to set transform. See logs for details"); + } } ///