fix: move removeIbl to render thread

thermion_dart/lib/src/viewer/src/ffi/src/thermion_viewer_ffi.dart

@@ -409,7 +409,9 @@ class ThermionViewerFFI extends ThermionViewer {
   ///
   @override
   Future removeIbl() async {
-    remove_ibl(_viewer!);
+    await withVoidCallback((cb) {
+      Viewer_removeIblRenderThread(_viewer!, cb);
+    });
   }
 
   @override

thermion_dart/native/include/c_api/ThermionDartApi.h

@@ -62,10 +62,11 @@ extern "C"
 	
 	EMSCRIPTEN_KEEPALIVE void load_skybox(TViewer *viewer, const char *skyboxPath);
 	EMSCRIPTEN_KEEPALIVE void Viewer_loadIbl(TViewer *viewer, const char *iblPath, float intensity);
+	EMSCRIPTEN_KEEPALIVE void Viewer_removeIbl(TViewer *viewer);
 	EMSCRIPTEN_KEEPALIVE void create_ibl(TViewer *viewer, float r, float g, float b, float intensity);
 	EMSCRIPTEN_KEEPALIVE void rotate_ibl(TViewer *viewer, float *rotationMatrix);
 	EMSCRIPTEN_KEEPALIVE void remove_skybox(TViewer *viewer);
-	EMSCRIPTEN_KEEPALIVE void remove_ibl(TViewer *viewer);
+	
 	
 	EMSCRIPTEN_KEEPALIVE EntityId get_main_camera(TViewer *viewer);
 	

thermion_dart/native/include/c_api/ThermionDartRenderThreadApi.h

@@ -38,6 +38,7 @@ namespace thermion
         EMSCRIPTEN_KEEPALIVE void Viewer_captureRenderTargetRenderThread(TViewer *viewer, TView *view, TSwapChain *swapChain, TRenderTarget *renderTarget, uint8_t *out, void (*onComplete)());
         EMSCRIPTEN_KEEPALIVE void Viewer_requestFrameRenderThread(TViewer *viewer, void (*onComplete)());
         EMSCRIPTEN_KEEPALIVE void Viewer_loadIblRenderThread(TViewer *viewer, const char *iblPath, float intensity, void (*onComplete)());
+        EMSCRIPTEN_KEEPALIVE void Viewer_removeIblRenderThread(TViewer *viewer, void (*onComplete)());
         EMSCRIPTEN_KEEPALIVE void Viewer_createRenderTargetRenderThread(TViewer *viewer, intptr_t texture, uint32_t width, uint32_t height, void (*onComplete)(TRenderTarget *));
         EMSCRIPTEN_KEEPALIVE void Viewer_destroyRenderTargetRenderThread(TViewer *viewer, TRenderTarget *tRenderTarget, void (*onComplete)());
 

thermion_dart/native/src/c_api/ThermionDartApi.cpp

@@ -89,6 +89,11 @@ extern "C"
         ((FilamentViewer *)viewer)->loadIbl(iblPath, intensity);
     }
 
+    EMSCRIPTEN_KEEPALIVE void Viewer_removeIbl(TViewer *viewer)
+    {
+        ((FilamentViewer *)viewer)->removeIbl();
+    }
+
     EMSCRIPTEN_KEEPALIVE void rotate_ibl(TViewer *viewer, float *rotationMatrix)
     {
         math::mat3f matrix(rotationMatrix[0], rotationMatrix[1],
@@ -108,10 +113,6 @@ extern "C"
         ((FilamentViewer *)viewer)->removeSkybox();
     }
 
-    EMSCRIPTEN_KEEPALIVE void remove_ibl(TViewer *viewer)
-    {
-        ((FilamentViewer *)viewer)->removeIbl();
-    }
 
     EMSCRIPTEN_KEEPALIVE int get_instance_count(TSceneManager *sceneManager, EntityId entityId)
     {

thermion_dart/native/src/c_api/ThermionDartRenderThreadApi.cpp

@@ -268,6 +268,17 @@ extern "C"
     auto fut = _rl->add_task(lambda);
   }
 
+  EMSCRIPTEN_KEEPALIVE void Viewer_removeIblRenderThread(TViewer *viewer, void (*onComplete)())
+  {
+    std::packaged_task<void()> lambda(
+        [=]() mutable
+        {
+          Viewer_removeIbl(viewer);
+          onComplete();
+        });
+    auto fut = _rl->add_task(lambda);
+  }
+
   EMSCRIPTEN_KEEPALIVE void Viewer_createRenderTargetRenderThread(TViewer *viewer, intptr_t texture, uint32_t width, uint32_t height, void (*onComplete)(TRenderTarget *))
   {
     std::packaged_task<void()> lambda(
@@ -549,13 +560,6 @@ extern "C"
     auto fut = _rl->add_task(lambda);
   }
 
-  EMSCRIPTEN_KEEPALIVE void remove_ibl_render_thread(TViewer *viewer)
-  {
-    std::packaged_task<void()> lambda([=]
-                                      { remove_ibl(viewer); });
-    auto fut = _rl->add_task(lambda);
-  }
-
   EMSCRIPTEN_KEEPALIVE void View_setToneMappingRenderThread(TView *tView, TEngine *tEngine, thermion::ToneMapping toneMapping)
   {
     std::packaged_task<void()> lambda(

thermion_dart/test/light_tests.dart

@@ -18,5 +18,17 @@ void main() async {
         await testHelper.capture(viewer, "remove_lights");
       });
     });
+
+    test('add/remove IBL', () async {
+      await testHelper.withViewer((viewer) async {
+        await viewer.loadGlb("file://${testHelper.testDir}/assets/cube.glb");
+
+        await viewer
+            .loadIbl("file://${testHelper.testDir}/assets/default_env_ibl.ktx");
+        await testHelper.capture(viewer, "load_ibl");
+        await viewer.removeIbl();
+        await testHelper.capture(viewer, "remove_ibl");
+      });
+    });
   });
 }