maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix!: (web/wasm) free pick callbacks on dispose

Browse Source
This commit is contained in:
Nick Fisher
2024-09-25 21:50:31 +08:00
parent 92fbe2e5d5
commit 85dcd5a5b9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
thermion_dart/lib/thermion_dart/viewer/web_wasm/src/thermion_viewer_wasm.dart
View File

@@ -127,8 +127,6 @@ class ThermionViewerWasm implements ThermionViewer {
_pickCallbackPtr = _module!.addFunction(_onPickCallback.toJS, "viii");
_pickGizmoCallbackPtr =
_module!.addFunction(_onPickGizmoCallback.toJS, "viii");
// _module!.removeFunction(_pickCallbackPtr);
// _module!.removeFunction(_pickGizmoCallbackPtr);
var gizmoOut = _module!._malloc(4 * 4);
@@ -237,6 +235,8 @@ class ThermionViewerWasm implements ThermionViewer {
await callback.call();
}
_onDispose.clear();
_module!.removeFunction(_pickCallbackPtr);
_module!.removeFunction(_pickGizmoCallbackPtr);
}
void _destroyViewer() {