maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

culling fixes for HighlightOverlay

Browse Source
This commit is contained in:
Nick Fisher
2024-09-13 10:34:47 +08:00
parent 44078ba2e0
commit 90827ff012
1 changed files with 83 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
thermion_dart/native/src/HighlightOverlay.cpp
View File

@@ -4,7 +4,8 @@
#include "SceneManager.hpp"
namespace thermion_filament {
namespace thermion_filament
{
SceneManager::HighlightOverlay::HighlightOverlay(
EntityId entityId,
@@ -12,7 +13,8 @@ namespace thermion_filament {
Engine *engine,
float r,
float g,
float b) : _sceneManager(sceneManager), _engine(engine) {
float b) : _sceneManager(sceneManager), _engine(engine)
{
auto &rm = engine->getRenderableManager();
@@ -25,28 +27,34 @@ namespace thermion_filament {
auto materialProvider = sceneManager->unlitMaterialProvider();
_highlightMaterialInstance = materialProvider->createMaterialInstance(&dummyKey, &dummyUvMap);
_highlightMaterialInstance->setDoubleSided(false);
_highlightMaterialInstance->setStencilOpStencilFail(filament::backend::StencilOperation::KEEP);
_highlightMaterialInstance->setStencilOpDepthFail(filament::backend::StencilOperation::KEEP);
_highlightMaterialInstance->setStencilOpDepthStencilPass(filament::backend::StencilOperation::KEEP);
_highlightMaterialInstance->setStencilOpDepthStencilPass(filament::backend::StencilOperation::REPLACE);
_highlightMaterialInstance->setStencilCompareFunction(filament::backend::SamplerCompareFunc::NE);
_highlightMaterialInstance->setStencilReferenceValue(1);
_highlightMaterialInstance->setParameter("color", filament::math::float3{r, g, b});
_highlightMaterialInstance->setParameter("scale", 1.05f);
_highlightMaterialInstance->setParameter("scale", 1.04f);
_highlightMaterialInstance->setCullingMode(filament::backend::CullingMode::FRONT);
auto scene = sceneManager->getScene();
_isGeometryEntity = sceneManager->isGeometryEntity(entityId);
_isGltfAsset = sceneManager->isGltfAsset(entityId);
if(!(_isGeometryEntity || _isGltfAsset)) {
if (!(_isGeometryEntity || _isGltfAsset))
{
Log("Failed to set stencil outline for entity %d: the entity is a child of another entity. "
"Currently, we only support outlining top-level entities."
"Call getAncestor() to get the ancestor of this entity, then set on that", entityId);
"Call getAncestor() to get the ancestor of this entity, then set on that",
entityId);
return;
}
if(_isGeometryEntity) {
if (_isGeometryEntity)
{
Log("Entity %d is geometry", entityId);
@@ -60,9 +68,10 @@ namespace thermion_filament {
materialInstance->setDepthWrite(true);
materialInstance->setStencilReferenceValue(1);
materialInstance->setStencilOpStencilFail(filament::backend::StencilOperation::KEEP);
materialInstance->setStencilOpDepthFail(filament::backend::StencilOperation::REPLACE);
materialInstance->setStencilOpDepthStencilPass(filament::backend::StencilOperation::REPLACE);
materialInstance->setStencilOpDepthFail(filament::backend::StencilOperation::KEEP);
materialInstance->setStencilOpDepthStencilPass(filament::backend::StencilOperation::KEEP);
materialInstance->setStencilCompareFunction(filament::backend::SamplerCompareFunc::A);
// materialInstance->setCullingMode(filament::MaterialInstance::CullingMode::BACK);
auto geometry = sceneManager->getGeometry(entityId);
@@ -72,6 +81,7 @@ namespace thermion_filament {
.geometry(0, geometry->primitiveType, geometry->vertexBuffer(), geometry->indexBuffer(), 0, geometry->numIndices)
.culling(true)
.material(0, _highlightMaterialInstance)
.priority(0)
.receiveShadows(false)
.castShadows(false);
@@ -81,7 +91,9 @@ namespace thermion_filament {
auto outlineTransformInstance = tm.getInstance(_entity);
auto entityTransformInstance = tm.getInstance(geometryEntity);
tm.setParent(outlineTransformInstance, entityTransformInstance);
} else if(_isGltfAsset) {
}
else if (_isGltfAsset)
{
Log("Entity %d is gltf", entityId);
auto *asset = sceneManager->getAssetByEntityId(entityId);
@@ -90,7 +102,6 @@ namespace thermion_filament {
Log("Found glTF FilamentAsset with %d material instances", asset->getInstance()->getMaterialInstanceCount());
auto materialInstance = asset->getInstance()->getMaterialInstances()[0];
// set stencil write on the existing material
@@ -110,53 +121,64 @@ namespace thermion_filament {
auto entityTransformInstance = tm.getInstance(asset->getRoot());
tm.setParent(newTransformInstance, entityTransformInstance);
if(!_newInstance) {
if (!_newInstance)
{
Log("Couldn't create new instance");
} else {
for(int i = 0; i < _newInstance->getEntityCount(); i++) {
}
else
{
for (int i = 0; i < _newInstance->getEntityCount(); i++)
{
auto entity = _newInstance->getEntities()[i];
auto renderableInstance = rm.getInstance(entity);
rm.setPriority(renderableInstance, 7);
if(renderableInstance.isValid()) {
for(int primitiveIndex = 0; primitiveIndex < rm.getPrimitiveCount(renderableInstance); primitiveIndex++) {
if (renderableInstance.isValid())
{
for (int primitiveIndex = 0; primitiveIndex < rm.getPrimitiveCount(renderableInstance); primitiveIndex++)
{
rm.setMaterialInstanceAt(renderableInstance, primitiveIndex, _highlightMaterialInstance);
}
} else {
}
else
{
Log("Not renderable, ignoring");
}
}
scene->addEntities(_newInstance->getEntities(), _newInstance->getEntityCount());
}
} else {
}
else
{
Log("Not FilamentAsset");
}
}
}
SceneManager::HighlightOverlay::~HighlightOverlay() {
Log("Destructor");
if (_entity.isNull()) {
SceneManager::HighlightOverlay::~HighlightOverlay()
{
if (_entity.isNull())
{
Log("Null entity");
return;
}
if (_isGltfAsset)
{
Log("Erasing new instance");
_sceneManager->getScene()->removeEntities(_newInstance->getEntities(), _newInstance->getEntityCount());
_newInstance->detachMaterialInstances();
_engine->destroy(_highlightMaterialInstance);
} else if(_isGeometryEntity) {
Log("Erasing new geometry");
}
else if (_isGeometryEntity)
{
auto &tm = _engine->getTransformManager();
auto transformInstance = tm.getInstance(_entity);
_sceneManager->getScene()->remove(_entity);
utils::EntityManager::get().destroy(_entity);
_engine->destroy(_entity);
_engine->destroy(_highlightMaterialInstance);
} else {
}
else
{
Log("FATAL: Unknown highlight overlay entity type");
}
}