maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove uvScale parameter from SceneManager and add some explicit logging

Browse Source
This commit is contained in:
Nick Fisher
2024-11-15 22:24:30 +08:00
parent 52f041afba
commit 9853d6b721
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
thermion_dart/native/src/SceneManager.cpp
View File

@@ -265,7 +265,8 @@ namespace thermion
auto renderable = rm.getInstance(utils::Entity::import(entityId)); auto renderable = rm.getInstance(utils::Entity::import(entityId));
if (!renderable.isValid()) if (!renderable.isValid())
{ {
Log("Warning: no renderable found"); Log("SceneManager::setVisibilityLayer - entity %d has no Renderable component", entityId);
return;
} }
rm.setLayerMask(renderable, 0xFF, 1u << layer); rm.setLayerMask(renderable, 0xFF, 1u << layer);
@@ -2216,7 +2217,7 @@ namespace thermion
auto renderableInstance = rm.getInstance(Entity::import(entityId)); auto renderableInstance = rm.getInstance(Entity::import(entityId));
if (!renderableInstance.isValid()) if (!renderableInstance.isValid())
{ {
Log("Error: invalid renderable, did you pass the correct entity?", priority); Log("SceneManager::setPriority entity %d has no renderable component", entityId);
return; return;
} }
rm.setPriority(renderableInstance, priority); rm.setPriority(renderableInstance, priority);
@@ -2533,7 +2534,6 @@ namespace thermion
{ {
UvMap uvmap; UvMap uvmap;
auto instance = _unlitMaterialProvider->createMaterialInstance(nullptr, &uvmap); auto instance = _unlitMaterialProvider->createMaterialInstance(nullptr, &uvmap);
instance->setParameter("uvScale", filament::math::float2{1.0f, 1.0f});
_materialInstances.push_back(instance); _materialInstances.push_back(instance);
return instance; return instance;
} }