maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

internal: set dynamicResolution enabled by default, set frameInterval properly, set bloom disabled by default

Browse Source
This commit is contained in:
Nick Fisher
2025-01-10 08:33:41 +08:00
parent 61abed2fb7
commit a178035796
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
thermion_dart/native/src/FilamentViewer.cpp
View File

@@ -141,17 +141,13 @@ namespace thermion
_engine = Engine::create(Engine::Backend::OPENGL, (backend::Platform *)platform, (void *)sharedContext, nullptr); _engine = Engine::create(Engine::Backend::OPENGL, (backend::Platform *)platform, (void *)sharedContext, nullptr);
#endif #endif
_engine->setAutomaticInstancingEnabled(true);
_renderer = _engine->createRenderer(); _renderer = _engine->createRenderer();
Renderer::ClearOptions clearOptions; Renderer::ClearOptions clearOptions;
clearOptions.clear = true; clearOptions.clear = true;
_renderer->setClearOptions(clearOptions); _renderer->setClearOptions(clearOptions);
_frameInterval = 1000.0f / 60.0f; setFrameInterval(60.0f);
setFrameInterval(_frameInterval);
_scene = _engine->createScene(); _scene = _engine->createScene();
@@ -177,10 +173,8 @@ namespace thermion
void FilamentViewer::setFrameInterval(float frameInterval) void FilamentViewer::setFrameInterval(float frameInterval)
{ {
_frameInterval = frameInterval;
Renderer::FrameRateOptions fro; Renderer::FrameRateOptions fro;
fro.interval = 1; // frameInterval; fro.interval = frameInterval / 60.0; // TODO don't hardcode display refresh rate
fro.history = 5;
_renderer->setFrameRateOptions(fro); _renderer->setFrameRateOptions(fro);
} }
@@ -660,7 +654,7 @@ namespace thermion
view->setBlendMode(filament::View::BlendMode::TRANSLUCENT); view->setBlendMode(filament::View::BlendMode::TRANSLUCENT);
view->setStencilBufferEnabled(true); view->setStencilBufferEnabled(true);
view->setAmbientOcclusionOptions({.enabled = false}); view->setAmbientOcclusionOptions({.enabled = false});
view->setDynamicResolutionOptions({.enabled = false}); view->setDynamicResolutionOptions({.enabled = true});
ACESToneMapper tm; ACESToneMapper tm;
auto colorGrading = ColorGrading::Builder().toneMapper(&tm).build(*_engine); auto colorGrading = ColorGrading::Builder().toneMapper(&tm).build(*_engine);
view->setColorGrading(colorGrading); view->setColorGrading(colorGrading);
@@ -668,10 +662,7 @@ namespace thermion
view->setStereoscopicOptions({.enabled = false}); view->setStereoscopicOptions({.enabled = false});
#endif #endif
// bloom can be a bit glitchy (some Intel iGPUs won't render when postprocessing is enabled and bloom is disabled, view->setBloomOptions({.strength = 0, .enabled=false });
// and render targets on MacOS flicker when bloom is disabled.
// Here, we enable bloom, but set to 0 strength
view->setBloomOptions({.strength = 0, .enabled=true });
view->setShadowingEnabled(false); view->setShadowingEnabled(false);
view->setScreenSpaceRefractionEnabled(false); view->setScreenSpaceRefractionEnabled(false);
view->setPostProcessingEnabled(false); view->setPostProcessingEnabled(false);