maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

correctly complete completer when resizing while unmounted and log any errors on resize

Browse Source
This commit is contained in:
Nick Fisher
2023-11-01 14:05:49 +08:00
parent 214510b595
commit a366867d91
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/widgets/filament_widget.dart
View File

@@ -171,20 +171,27 @@ class _SizedFilamentWidgetState extends State<_SizedFilamentWidget> {
Duration(milliseconds: (kReleaseMode || Platform.isWindows) ? 10 : 100), Duration(milliseconds: (kReleaseMode || Platform.isWindows) ? 10 : 100),
() async { () async {
if (!mounted) { if (!mounted) {
completer.complete();
return; return;
} }
while (_resizing) { try {
await Future.delayed(const Duration(milliseconds: 20)); while (_resizing) {
} await Future.delayed(const Duration(milliseconds: 20));
}
_resizing = true; _resizing = true;
await widget.controller.setDimensions(_rect, _pixelRatio); await widget.controller.setDimensions(_rect, _pixelRatio);
await widget.controller.resize(); await widget.controller.resize();
_resizeTimer = null; _resizeTimer = null;
setState(() {}); setState(() {});
_resizing = false; _resizing = false;
completer.complete(); } catch (err) {
print("Error resizing FilamentWidget: $err");
} finally {
completer.complete();
}
}); });
return completer.future; return completer.future;
} }