maobo/cup_edit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(Windows) properly destroy swapchain and don't un-set current unless the swapchain being destroyed is the current swapchain

Browse Source
This commit is contained in:
Nick Fisher
2025-04-16 13:35:40 +08:00
parent 7dfb8a4b19
commit d3b9ae45cf
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
thermion_dart/native/src/windows/vulkan/vulkan_platform.cpp
View File

@@ -25,10 +25,11 @@ namespace thermion::windows::vulkan {
TVulkanPlatform::TVulkanPlatform() { TVulkanPlatform::TVulkanPlatform() {
_customization.gpu.index = 0; _customization.gpu.index = 0;
TRACE("Set GPU index to 1");
} }
TVulkanPlatform::~TVulkanPlatform() { TVulkanPlatform::~TVulkanPlatform() {
std::cerr << "Destroyed Vulkan platform" << std::endl; TRACE("Destroyed Vulkan platform");
} }
filament::backend::VulkanPlatform::Customization TVulkanPlatform::getCustomization() const noexcept { filament::backend::VulkanPlatform::Customization TVulkanPlatform::getCustomization() const noexcept {
@@ -39,14 +40,17 @@ filament::backend::VulkanPlatform::SwapChainPtr TVulkanPlatform::createSwapChain
VkExtent2D extent) { VkExtent2D extent) {
std::lock_guard lock(mutex); std::lock_guard lock(mutex);
current = filament::backend::VulkanPlatform::createSwapChain(nativeWindow, flags, extent); current = filament::backend::VulkanPlatform::createSwapChain(nativeWindow, flags, extent);
std::cerr << "Created swap chain with flags " << flags << std::endl; TRACE("Created swap chain with flags %d", flags);
return current; return current;
} }
void TVulkanPlatform::destroy(filament::backend::VulkanPlatform::SwapChainPtr handle) { void TVulkanPlatform::destroy(filament::backend::VulkanPlatform::SwapChainPtr handle) {
std::lock_guard lock(mutex); std::lock_guard lock(mutex);
current = nullptr; filament::backend::VulkanPlatform::destroy(handle);
std::cerr << "Destroyed swap chain" << std::endl; if(handle == current) {
current = nullptr;
}
TRACE("Destroyed swap chain");
} }
VkResult TVulkanPlatform::present(SwapChainPtr handle, uint32_t index, VkSemaphore finishedDrawing) { VkResult TVulkanPlatform::present(SwapChainPtr handle, uint32_t index, VkSemaphore finishedDrawing) {