chore: rename Viewer_destroyOnRenderThread method and cleanup unused SwapChain parameter in render threa

This commit is contained in:
Nick Fisher
2024-10-22 12:42:19 +08:00
parent cb517c907d
commit 9bec96f160
3 changed files with 19 additions and 26 deletions

View File

@@ -27,7 +27,6 @@ public:
~RenderLoop()
{
_stop = true;
swapChain = nullptr;
_cv.notify_one();
t->join();
}
@@ -125,7 +124,6 @@ public:
{
std::packaged_task<void()> lambda([=]() mutable
{
swapChain = nullptr;
_viewer = nullptr;
destroy_filament_viewer(reinterpret_cast<TViewer*>(viewer)); });
auto fut = add_task(lambda);
@@ -158,9 +156,6 @@ public:
return ret;
}
public:
TSwapChain *swapChain;
private:
void(*_requestFrameRenderCallback)() = nullptr;
bool _stop = false;
@@ -200,7 +195,7 @@ extern "C"
renderCallback, renderCallbackOwner, callback);
}
EMSCRIPTEN_KEEPALIVE void destroy_filament_viewer_render_thread(TViewer *viewer)
EMSCRIPTEN_KEEPALIVE void Viewer_destroyOnRenderThread(TViewer *viewer)
{
_rl->destroyViewer((FilamentViewer *)viewer);
delete _rl;